Add initial scripts for image maintainers to use to auto-generate appropriate GitHub Actions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a little testing on this and was able to make it work reasonably transparently with |
…mes (quietly adjust PATH if bashbrew is already built)
tianon
force-pushed
the
downstream-github-actions
branch
from
999dc3f to
b22f02e
Compare
|
Very successful non- |
yosifkit
approved these changes
Apr 28, 2020
This was referenced Apr 28, 2020
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (plus docker-library/official-images#7888) has been used to successfully run tests in GitHub actions across the following images:
python: https://github.com/docker-library/python/actions/runs/89429902mongo: https://github.com/docker-library/mongo/actions/runs/89359532openjdk: https://github.com/docker-library/openjdk/actions/runs/89385581julia: https://github.com/docker-library/julia/actions/runs/89398688golang: https://github.com/docker-library/golang/actions/runs/89404277postgres: https://github.com/docker-library/postgres/actions/runs/89429254I've not done much testing/thinking around how I'd use this as a non-
docker-librarymaintainer (esp. around my personal repos which I use this pattern for maintaining, for example), but I think this gives us a solid base to move outwards from.Most of this was made possible by https://github.blog/changelog/2020-04-15-github-actions-new-workflow-features/ -- I was hoping we could take this a step further and have the script directly generate
steps:values (because that's way nicer looking, especially for builds that do multiple images; https://twitter.com/tianon/status/1253032501796147200), but the answer is no (maybe "not yet?" 🤞 😅).